[GitHub] accumulo-examples pull request #5: Fixed logging

classic Classic list List threaded Threaded
6 messages Options
Reply | Threaded
Open this post in threaded view
|

[GitHub] accumulo-examples pull request #5: Fixed logging

ctubbsii
GitHub user milleruntime opened a pull request:

    https://github.com/apache/accumulo-examples/pull/5

    Fixed logging

   

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/milleruntime/accumulo-examples master

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/accumulo-examples/pull/5.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #5
   
----
commit 16038a231644341ae8a182f605946913c9a5b781
Author: Mike Miller <[hidden email]>
Date:   2017-02-22T17:33:22Z

    Fixed logging

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|

[GitHub] accumulo-examples pull request #5: Fixed logging

ctubbsii
Github user ctubbsii commented on a diff in the pull request:

    https://github.com/apache/accumulo-examples/pull/5#discussion_r102531924
 
    --- Diff: bin/runex ---
    @@ -22,4 +22,4 @@ if command -v accumulo > /dev/null 2>&1 ; then
       av_arg="-Daccumulo.version=`accumulo version`"
     fi
     
    -mvn -q exec:java -Dexec.mainClass="org.apache.accumulo.examples.$main_class" $av_arg -Dexec.args="$main_args"
    +mvn -q exec:java -Dexec.mainClass="org.apache.accumulo.examples.$main_class" $av_arg -Dexec.args="$main_args" -Dlog4j.configuration=file:"./src/main/resources/log4j.properties"
    --- End diff --
   
    Not sure this part is necessary, since the default is to use the `log4j.properties` from the class path. Putting the file in `src/main/resources` should be sufficient to get it on the classpath.
   
    The above will also fail if the `runex` command is not executed from the root of the project as `bin/runex`. From any other directory, the relative path won't work.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|

[GitHub] accumulo-examples pull request #5: Fixed logging

ctubbsii
In reply to this post by ctubbsii
Github user milleruntime commented on a diff in the pull request:

    https://github.com/apache/accumulo-examples/pull/5#discussion_r102534074
 
    --- Diff: bin/runex ---
    @@ -22,4 +22,4 @@ if command -v accumulo > /dev/null 2>&1 ; then
       av_arg="-Daccumulo.version=`accumulo version`"
     fi
     
    -mvn -q exec:java -Dexec.mainClass="org.apache.accumulo.examples.$main_class" $av_arg -Dexec.args="$main_args"
    +mvn -q exec:java -Dexec.mainClass="org.apache.accumulo.examples.$main_class" $av_arg -Dexec.args="$main_args" -Dlog4j.configuration=file:"./src/main/resources/log4j.properties"
    --- End diff --
   
    I will run it again without the -D to make sure its on the classpath.
   
    Yeah I realized it was a relative path but the runex command doesn't work outside the root of the project anyway...


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|

[GitHub] accumulo-examples pull request #5: Fixed logging

ctubbsii
In reply to this post by ctubbsii
Github user ctubbsii commented on a diff in the pull request:

    https://github.com/apache/accumulo-examples/pull/5#discussion_r102534520
 
    --- Diff: bin/runex ---
    @@ -22,4 +22,4 @@ if command -v accumulo > /dev/null 2>&1 ; then
       av_arg="-Daccumulo.version=`accumulo version`"
     fi
     
    -mvn -q exec:java -Dexec.mainClass="org.apache.accumulo.examples.$main_class" $av_arg -Dexec.args="$main_args"
    +mvn -q exec:java -Dexec.mainClass="org.apache.accumulo.examples.$main_class" $av_arg -Dexec.args="$main_args" -Dlog4j.configuration=file:"./src/main/resources/log4j.properties"
    --- End diff --
   
    > the runex command doesn't work outside the root of the project anyway...
   
    Good point.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|

[GitHub] accumulo-examples pull request #5: Fixed logging

ctubbsii
In reply to this post by ctubbsii
Github user milleruntime commented on a diff in the pull request:

    https://github.com/apache/accumulo-examples/pull/5#discussion_r102537989
 
    --- Diff: bin/runex ---
    @@ -22,4 +22,4 @@ if command -v accumulo > /dev/null 2>&1 ; then
       av_arg="-Daccumulo.version=`accumulo version`"
     fi
     
    -mvn -q exec:java -Dexec.mainClass="org.apache.accumulo.examples.$main_class" $av_arg -Dexec.args="$main_args"
    +mvn -q exec:java -Dexec.mainClass="org.apache.accumulo.examples.$main_class" $av_arg -Dexec.args="$main_args" -Dlog4j.configuration=file:"./src/main/resources/log4j.properties"
    --- End diff --
   
    Moot point now... compiling with it in src/main/resources puts it on the classpath.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|

[GitHub] accumulo-examples pull request #5: Fixed logging

ctubbsii
In reply to this post by ctubbsii
Github user asfgit closed the pull request at:

    https://github.com/apache/accumulo-examples/pull/5


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---