[GitHub] accumulo pull request #226: ACCUMULO-4594 Fix Kerberos documentation

classic Classic list List threaded Threaded
7 messages Options
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] accumulo pull request #226: ACCUMULO-4594 Fix Kerberos documentation

joshelser
GitHub user mikewalch opened a pull request:

    https://github.com/apache/accumulo/pull/226

    ACCUMULO-4594 Fix Kerberos documentation

    * Added documentation for configuring Kerberos using 2.0.0 scripts
    * Removed kerberos config file references from accumulo command as
      these can be added by user to JAVA_OPTS in accumulo-env.sh

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/mikewalch/accumulo accumulo-4594

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/accumulo/pull/226.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #226
   
----
commit 3f935e017799987c3ac9c90be5f608af1f99cb24
Author: Mike Walch <[hidden email]>
Date:   2017-03-01T22:28:15Z

    ACCUMULO-4594 Fix Kerberos documentation
   
    * Added documentation for configuring Kerberos using 2.0.0 scripts
    * Removed kerberos config file references from accumulo command as
      these can be added by user to JAVA_OPTS in accumulo-env.sh

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] accumulo pull request #226: ACCUMULO-4594 Fix Kerberos documentation

joshelser
Github user keith-turner commented on a diff in the pull request:

    https://github.com/apache/accumulo/pull/226#discussion_r103967640
 
    --- Diff: assemble/bin/accumulo ---
    @@ -72,13 +72,6 @@ function main() {
       export HADOOP_HOME=$HADOOP_PREFIX
       export HADOOP_HOME_WARN_SUPPRESS=true
     
    -  if [ -f "${conf}/jaas.conf" ]; then
    -    export JAVA_OPTS=("${JAVA_OPTS[@]}" "-Djava.security.auth.login.config=${conf}/jaas.conf")
    --- End diff --
   
    Should this property be mentioned in any documentation?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] accumulo pull request #226: ACCUMULO-4594 Fix Kerberos documentation

joshelser
In reply to this post by joshelser
Github user mikewalch commented on a diff in the pull request:

    https://github.com/apache/accumulo/pull/226#discussion_r103973200
 
    --- Diff: assemble/bin/accumulo ---
    @@ -72,13 +72,6 @@ function main() {
       export HADOOP_HOME=$HADOOP_PREFIX
       export HADOOP_HOME_WARN_SUPPRESS=true
     
    -  if [ -f "${conf}/jaas.conf" ]; then
    -    export JAVA_OPTS=("${JAVA_OPTS[@]}" "-Djava.security.auth.login.config=${conf}/jaas.conf")
    --- End diff --
   
    There is no mention of `jaas.conf` anywhere in the documentation or the code.  Users can still add this JVM property to JAVA_OPTS in accumulo-env.sh but I don't see a point in documenting it as it was documented before.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] accumulo issue #226: ACCUMULO-4594 Fix Kerberos documentation

joshelser
In reply to this post by joshelser
Github user keith-turner commented on the issue:

    https://github.com/apache/accumulo/pull/226
 
    This is not related to this PR, but this PR made me think of it.  It would be really nice if the modified scripts warned when 1.x env vars are observed.  So if a 1.x env var thats no longer used or used differently, the scripts would detect this and print a message that guides the user on how to correct the issue.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] accumulo issue #226: ACCUMULO-4594 Fix Kerberos documentation

joshelser
In reply to this post by joshelser
Github user keith-turner commented on the issue:

    https://github.com/apache/accumulo/pull/226
 
    > This is not related to this PR, but this PR made me think of it.
   
    Actually, #225 made me think of that... not this PR.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] accumulo pull request #226: ACCUMULO-4594 Fix Kerberos documentation

joshelser
In reply to this post by joshelser
Github user asfgit closed the pull request at:

    https://github.com/apache/accumulo/pull/226


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] accumulo pull request #226: ACCUMULO-4594 Fix Kerberos documentation

joshelser
In reply to this post by joshelser
Github user joshelser commented on a diff in the pull request:

    https://github.com/apache/accumulo/pull/226#discussion_r104027458
 
    --- Diff: assemble/bin/accumulo ---
    @@ -72,13 +72,6 @@ function main() {
       export HADOOP_HOME=$HADOOP_PREFIX
       export HADOOP_HOME_WARN_SUPPRESS=true
     
    -  if [ -f "${conf}/jaas.conf" ]; then
    -    export JAVA_OPTS=("${JAVA_OPTS[@]}" "-Djava.security.auth.login.config=${conf}/jaas.conf")
    --- End diff --
   
    We don't need the JAAS configuration right now for ourselves, but that's only because of our use of DIGEST ACLs for authentication with ZooKeeper. I think I have an issue somewhere to switch to using SASL ACLs when we're using Kerberos elsewhere (but I can't find it at the moment).
   
    It _should_ be implied if that there is some code that needs to be deployed inside Accumulo that needs to perform a login via JAAS, that the user can specify their own JAAS configuration file. I don't think we need to be explicit (for now).



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Loading...