[GitHub] accumulo pull request #245: ACCUMULO-4620 Consolidate all Maven modules into...

classic Classic list List threaded Threaded
6 messages Options
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] accumulo pull request #245: ACCUMULO-4620 Consolidate all Maven modules into...

joshelser
GitHub user mikewalch opened a pull request:

    https://github.com/apache/accumulo/pull/245

    ACCUMULO-4620 Consolidate all Maven modules into one directory

    This PR is for master.  I am going to create PRs for 1.8 & 1.7 branches to make merging easier in the future.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/mikewalch/accumulo modules-dir-master

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/accumulo/pull/245.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #245
   
----
commit d781bbec75738723b94c94f3043a96e4520e3246
Author: Mike Walch <[hidden email]>
Date:   2017-04-07T16:14:59Z

    ACCUMULO-4620 Consolidate all Maven modules into one directory

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] accumulo pull request #245: ACCUMULO-4620 Consolidate all Maven modules into...

joshelser
Github user ctubbsii commented on a diff in the pull request:

    https://github.com/apache/accumulo/pull/245#discussion_r110495402
 
    --- Diff: pom.xml ---
    @@ -80,24 +80,24 @@
         <maven>${maven.min-version}</maven>
       </prerequisites>
       <modules>
    -    <module>assemble</module>
    -    <module>core</module>
    -    <module>docs</module>
    -    <module>fate</module>
    -    <module>iterator-test-harness</module>
    -    <module>maven-plugin</module>
    -    <module>minicluster</module>
    -    <module>proxy</module>
    -    <module>server/base</module>
    -    <module>server/gc</module>
    -    <module>server/master</module>
    -    <module>server/monitor</module>
    -    <module>server/native</module>
    -    <module>server/tracer</module>
    -    <module>server/tserver</module>
    -    <module>shell</module>
    -    <module>start</module>
    -    <module>test</module>
    +    <module>modules/assemble</module>
    +    <module>modules/core</module>
    +    <module>modules/docs</module>
    +    <module>modules/fate</module>
    +    <module>modules/iterator-test-harness</module>
    +    <module>modules/maven-plugin</module>
    +    <module>modules/minicluster</module>
    +    <module>modules/proxy</module>
    +    <module>modules/base</module>
    +    <module>modules/gc</module>
    +    <module>modules/master</module>
    +    <module>modules/monitor</module>
    +    <module>modules/native</module>
    +    <module>modules/tracer</module>
    +    <module>modules/tserver</module>
    +    <module>modules/shell</module>
    +    <module>modules/start</module>
    +    <module>modules/test</module>
    --- End diff --
   
    This changes the sort order. These aren't sorted any more.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] accumulo issue #245: ACCUMULO-4620 Consolidate all Maven modules into one di...

joshelser
In reply to this post by joshelser
Github user mikewalch commented on the issue:

    https://github.com/apache/accumulo/pull/245
 
    @ctubbsii, I will close this PR and only have the master PR open.  I wasn't sure about doing this change in the 1.8 & 1.7 branches but I opened as I thought it may make merging fixes to master easier.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] accumulo pull request #245: ACCUMULO-4620 Consolidate all Maven modules into...

joshelser
In reply to this post by joshelser
Github user mikewalch closed the pull request at:

    https://github.com/apache/accumulo/pull/245


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] accumulo pull request #245: ACCUMULO-4620 Consolidate all Maven modules into...

joshelser
In reply to this post by joshelser
GitHub user mikewalch reopened a pull request:

    https://github.com/apache/accumulo/pull/245

    ACCUMULO-4620 Consolidate all Maven modules into one directory (1.8)

    This PR is for master.  I am going to create PRs for 1.8 & 1.7 branches to make merging easier in the future.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/mikewalch/accumulo modules-dir-master

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/accumulo/pull/245.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #245
   
----
commit d781bbec75738723b94c94f3043a96e4520e3246
Author: Mike Walch <[hidden email]>
Date:   2017-04-07T16:14:59Z

    ACCUMULO-4620 Consolidate all Maven modules into one directory

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] accumulo pull request #245: ACCUMULO-4620 Consolidate all Maven modules into...

joshelser
In reply to this post by joshelser
Github user mikewalch closed the pull request at:

    https://github.com/apache/accumulo/pull/245


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Loading...