[GitHub] accumulo pull request #258: fixes ACCUMULO-4634 : Appropriately implement th...

classic Classic list List threaded Threaded
8 messages Options
Reply | Threaded
Open this post in threaded view
|

[GitHub] accumulo pull request #258: fixes ACCUMULO-4634 : Appropriately implement th...

ctubbsii
GitHub user ivakegg opened a pull request:

    https://github.com/apache/accumulo/pull/258

    fixes ACCUMULO-4634 : Appropriately implement the mocked out methods …

    …per the interface specifications.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/ivakegg/accumulo 1.8

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/accumulo/pull/258.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #258
   
----

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|

[GitHub] accumulo issue #258: fixes ACCUMULO-4634 : Appropriately implement the mocke...

ctubbsii
Github user joshelser commented on the issue:

    https://github.com/apache/accumulo/pull/258
 
    LGTM -- nice to see the semantics clear on IteratorEnvironment.
   
    Any interest in adding a unit test?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|

[GitHub] accumulo issue #258: fixes ACCUMULO-4634 : Appropriately implement the mocke...

ctubbsii
In reply to this post by ctubbsii
Github user ivakegg commented on the issue:

    https://github.com/apache/accumulo/pull/258
 
    I will see what I can do to force the MockAccumulo through that path.....


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|

[GitHub] accumulo issue #258: fixes ACCUMULO-4634 : Appropriately implement the mocke...

ctubbsii
In reply to this post by ctubbsii
Github user joshelser commented on the issue:

    https://github.com/apache/accumulo/pull/258
 
    bq. I will see what I can do to force the MockAccumulo through that path
   
    Oh, I don't think you need to do anything so high-level. Just instantiate the MockIteratorEnvironment and add test methods that verify what each of those methods you modified does :)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|

[GitHub] accumulo issue #258: fixes ACCUMULO-4634 : Appropriately implement the mocke...

ctubbsii
In reply to this post by ctubbsii
Github user ivakegg commented on the issue:

    https://github.com/apache/accumulo/pull/258
 
    tests added


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|

[GitHub] accumulo issue #258: fixes ACCUMULO-4634 : Appropriately implement the mocke...

ctubbsii
In reply to this post by ctubbsii
Github user joshelser commented on the issue:

    https://github.com/apache/accumulo/pull/258
 
    Thanks for the revisions, @ivakegg! Will try to commit later today.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|

[GitHub] accumulo issue #258: fixes ACCUMULO-4634 : Appropriately implement the mocke...

ctubbsii
In reply to this post by ctubbsii
Github user joshelser commented on the issue:

    https://github.com/apache/accumulo/pull/258
 
    > Will try to commit later today.
   
    I am also expanding the `*` import and squashing the commits together.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|

[GitHub] accumulo pull request #258: fixes ACCUMULO-4634 : Appropriately implement th...

ctubbsii
In reply to this post by ctubbsii
Github user asfgit closed the pull request at:

    https://github.com/apache/accumulo/pull/258


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---