[GitHub] accumulo pull request #265: ACCUMULO-4647 - start of contributor guide

classic Classic list List threaded Threaded
25 messages Options
12
Reply | Threaded
Open this post in threaded view
|

[GitHub] accumulo pull request #265: ACCUMULO-4647 - start of contributor guide

ctubbsii
GitHub user dlmarion opened a pull request:

    https://github.com/apache/accumulo/pull/265

    ACCUMULO-4647 - start of contributor guide

   

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/apache/accumulo ACCUMULO-4647

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/accumulo/pull/265.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #265
   
----
commit 8b6e8330cc17216f40198f3d22453b5a8405ea1f
Author: Dave Marion <[hidden email]>
Date:   2017-06-06T13:00:43Z

    ACCUMULO-4647 - start of contributor guide

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|

[GitHub] accumulo pull request #265: ACCUMULO-4647 - start of contributor guide

ctubbsii
Github user mikewalch commented on a diff in the pull request:

    https://github.com/apache/accumulo/pull/265#discussion_r120366191
 
    --- Diff: CONTRIBUTING.md ---
    @@ -0,0 +1,25 @@
    +# Contributors Guide
    +
    + If you believe that you have found a bug, please search for an existing [issue](https://issues.apache.org/jira/browse/accumulo) to see if it has already been reported. If you would like to add a new feature to Accumulo, please send an email with your idea to the [user](mailto:[hidden email]) mail list. If it's appropriate, then we will create a ticket and assign it to you.
    +
    +## Development
    +
    +- Ensure that your work targets the correct branch
    +- Add / update unit and integration tests
    +- Ensure that Accumulo builds cleanly using the command: `mvn clean verify`
    +
    +## Patch Submission
    +
    +- Before submission please squash your commits using a message that contains the JIRA issue number and a description of the changes.
    +- Patches should be submitted in the form of Pull Requests to the Apache Accumulo GitHub [repository](https://github.com/apache/accumulo/) or to the [Review Board](https://reviews.apache.org) accumulo repository.
    +
    +## Review
    +
    +- One or more committers will review your patch.
    +- They will be looking for things like threading issues, performance implications, API design, etc.
    +- Reviewers will likely ask questions to better understand your change - be prepared to answer them.
    --- End diff --
   
    I would remove `- be prepared to answer them`.  


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|

[GitHub] accumulo pull request #265: ACCUMULO-4647 - start of contributor guide

ctubbsii
In reply to this post by ctubbsii
Github user mikewalch commented on a diff in the pull request:

    https://github.com/apache/accumulo/pull/265#discussion_r120364815
 
    --- Diff: CONTRIBUTING.md ---
    @@ -0,0 +1,25 @@
    +# Contributors Guide
    +
    + If you believe that you have found a bug, please search for an existing [issue](https://issues.apache.org/jira/browse/accumulo) to see if it has already been reported. If you would like to add a new feature to Accumulo, please send an email with your idea to the [user](mailto:[hidden email]) mail list. If it's appropriate, then we will create a ticket and assign it to you.
    +
    +## Development
    +
    +- Ensure that your work targets the correct branch
    +- Add / update unit and integration tests
    +- Ensure that Accumulo builds cleanly using the command: `mvn clean verify`
    +
    +## Patch Submission
    +
    +- Before submission please squash your commits using a message that contains the JIRA issue number and a description of the changes.
    +- Patches should be submitted in the form of Pull Requests to the Apache Accumulo GitHub [repository](https://github.com/apache/accumulo/) or to the [Review Board](https://reviews.apache.org) accumulo repository.
    +
    +## Review
    +
    +- One or more committers will review your patch.
    +- They will be looking for things like threading issues, performance implications, API design, etc.
    --- End diff --
   
    If line above is changed then `They` should be `Reviewers`.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|

[GitHub] accumulo pull request #265: ACCUMULO-4647 - start of contributor guide

ctubbsii
In reply to this post by ctubbsii
Github user mikewalch commented on a diff in the pull request:

    https://github.com/apache/accumulo/pull/265#discussion_r120364297
 
    --- Diff: CONTRIBUTING.md ---
    @@ -0,0 +1,25 @@
    +# Contributors Guide
    +
    + If you believe that you have found a bug, please search for an existing [issue](https://issues.apache.org/jira/browse/accumulo) to see if it has already been reported. If you would like to add a new feature to Accumulo, please send an email with your idea to the [user](mailto:[hidden email]) mail list. If it's appropriate, then we will create a ticket and assign it to you.
    +
    +## Development
    +
    +- Ensure that your work targets the correct branch
    +- Add / update unit and integration tests
    +- Ensure that Accumulo builds cleanly using the command: `mvn clean verify`
    +
    +## Patch Submission
    +
    +- Before submission please squash your commits using a message that contains the JIRA issue number and a description of the changes.
    +- Patches should be submitted in the form of Pull Requests to the Apache Accumulo GitHub [repository](https://github.com/apache/accumulo/) or to the [Review Board](https://reviews.apache.org) accumulo repository.
    +
    +## Review
    +
    +- One or more committers will review your patch.
    --- End diff --
   
    Should be `While everyone is welcome to review patches, at least one committer needs to review and approve your patch.`


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|

[GitHub] accumulo pull request #265: ACCUMULO-4647 - start of contributor guide

ctubbsii
In reply to this post by ctubbsii
Github user mikewalch commented on a diff in the pull request:

    https://github.com/apache/accumulo/pull/265#discussion_r120360809
 
    --- Diff: CONTRIBUTING.md ---
    @@ -0,0 +1,25 @@
    +# Contributors Guide
    +
    + If you believe that you have found a bug, please search for an existing [issue](https://issues.apache.org/jira/browse/accumulo) to see if it has already been reported. If you would like to add a new feature to Accumulo, please send an email with your idea to the [user](mailto:[hidden email]) mail list. If it's appropriate, then we will create a ticket and assign it to you.
    --- End diff --
   
    Could change the email address to `[hidden email]` as its development related.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|

[GitHub] accumulo pull request #265: ACCUMULO-4647 - start of contributor guide

ctubbsii
In reply to this post by ctubbsii
Github user mikewalch commented on a diff in the pull request:

    https://github.com/apache/accumulo/pull/265#discussion_r120377137
 
    --- Diff: pom.xml ---
    @@ -832,6 +832,7 @@
                   <exclude>nbproject/**</exclude>
                   <exclude>nb-configuration.xml</exclude>
                   <exclude>nbactions.xml</exclude>
    +              <exclude>CONTRIBUTING.md</exclude>
    --- End diff --
   
    You can add the license header using markdown comments (i.e  `<!-- comment -->`) and not have exclude this file from RAT.  See the `README.md`


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|

[GitHub] accumulo issue #265: ACCUMULO-4647 - start of contributor guide

ctubbsii
In reply to this post by ctubbsii
Github user joshelser commented on the issue:

    https://github.com/apache/accumulo/pull/265
 
    @dlmarion did you look to https://accumulo.apache.org/contributor/source at all (I think this was mentioned in the thread yesterday)? At a glance, most of the info on that existing page wouldn't apply, but there might be some nice things to include (e.g. public API, checkstyle/formatter).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|

[GitHub] accumulo pull request #265: ACCUMULO-4647 - start of contributor guide

ctubbsii
In reply to this post by ctubbsii
Github user joshelser commented on a diff in the pull request:

    https://github.com/apache/accumulo/pull/265#discussion_r120384442
 
    --- Diff: CONTRIBUTING.md ---
    @@ -0,0 +1,25 @@
    +# Contributors Guide
    +
    + If you believe that you have found a bug, please search for an existing [issue](https://issues.apache.org/jira/browse/accumulo) to see if it has already been reported. If you would like to add a new feature to Accumulo, please send an email with your idea to the [user](mailto:[hidden email]) mail list. If it's appropriate, then we will create a ticket and assign it to you.
    +
    +## Development
    +
    +- Ensure that your work targets the correct branch
    +- Add / update unit and integration tests
    +- Ensure that Accumulo builds cleanly using the command: `mvn clean verify`
    +
    +## Patch Submission
    +
    +- Before submission please squash your commits using a message that contains the JIRA issue number and a description of the changes.
    --- End diff --
   
    How about: "using a message that starts with the JIRA issue number". I could see the current text being misconstrued (e.g. `foo bar baz ACCUMULO-XXXX` or `XXXX foo bar baz`)
   
    We're quite consistent with commit messages being `ACCUMULO-XXXX foo bar baz` (with more text after a line break)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|

[GitHub] accumulo pull request #265: ACCUMULO-4647 - start of contributor guide

ctubbsii
In reply to this post by ctubbsii
Github user joshelser commented on a diff in the pull request:

    https://github.com/apache/accumulo/pull/265#discussion_r120383976
 
    --- Diff: CONTRIBUTING.md ---
    @@ -0,0 +1,25 @@
    +# Contributors Guide
    +
    + If you believe that you have found a bug, please search for an existing [issue](https://issues.apache.org/jira/browse/accumulo) to see if it has already been reported. If you would like to add a new feature to Accumulo, please send an email with your idea to the [user](mailto:[hidden email]) mail list. If it's appropriate, then we will create a ticket and assign it to you.
    +
    +## Development
    +
    +- Ensure that your work targets the correct branch
    +- Add / update unit and integration tests
    +- Ensure that Accumulo builds cleanly using the command: `mvn clean verify`
    --- End diff --
   
    I think the intent is that `mvn verify` passes before the change is submitted, but this reads as those devs should always use that (when in practice, `mvn package` might be just fine).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|

[GitHub] accumulo issue #265: ACCUMULO-4647 - start of contributor guide

ctubbsii
In reply to this post by ctubbsii
Github user dlmarion commented on the issue:

    https://github.com/apache/accumulo/pull/265
 
    Made modifications based on comments from @mikewalch  and @joshelser.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|

[GitHub] accumulo issue #265: ACCUMULO-4647 - start of contributor guide

ctubbsii
In reply to this post by ctubbsii
Github user mikewalch commented on the issue:

    https://github.com/apache/accumulo/pull/265
 
    +1 Updates look good to me.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|

[GitHub] accumulo pull request #265: ACCUMULO-4647 - start of contributor guide

ctubbsii
In reply to this post by ctubbsii
Github user keith-turner commented on a diff in the pull request:

    https://github.com/apache/accumulo/pull/265#discussion_r120389734
 
    --- Diff: CONTRIBUTING.md ---
    @@ -0,0 +1,43 @@
    +<!--
    +Licensed to the Apache Software Foundation (ASF) under one or more
    +contributor license agreements.  See the NOTICE file distributed with
    +this work for additional information regarding copyright ownership.
    +The ASF licenses this file to You under the Apache License, Version 2.0
    +(the "License"); you may not use this file except in compliance with
    +the License.  You may obtain a copy of the License at
    +
    +    http://www.apache.org/licenses/LICENSE-2.0
    +
    +Unless required by applicable law or agreed to in writing, software
    +distributed under the License is distributed on an "AS IS" BASIS,
    +WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    +See the License for the specific language governing permissions and
    +limitations under the License.
    +-->
    +
    +# Contributors Guide
    +
    + If you believe that you have found a bug, please search for an existing [issue](https://issues.apache.org/jira/browse/accumulo) to see if it has already been reported. If you would like to add a new feature to Accumulo, please send an email with your idea to the [dev](mailto:[hidden email]) mail list. If it's appropriate, then we will create a ticket and assign it to you.
    +
    +## Development
    +
    +- See the [Developer's Guide](https://accumulo.apache.org/contributor/source) for information regarding common build commands, IDE setup and more.
    +- Ensure that your work targets the correct branch
    +- Add / update unit and integration tests
    +
    +## Patch Submission
    +
    +- Ensure that Accumulo builds cleanly before submiting your patch using the command: `mvn clean verify`
    --- End diff --
   
    Do we really want to recommend/require `mvn clean verify`?  That takes a long time.  What about `mvn clean verify -Psunny` of `mvn clean verify -DskipITs`?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|

[GitHub] accumulo pull request #265: ACCUMULO-4647 - start of contributor guide

ctubbsii
In reply to this post by ctubbsii
Github user keith-turner commented on a diff in the pull request:

    https://github.com/apache/accumulo/pull/265#discussion_r120391121
 
    --- Diff: CONTRIBUTING.md ---
    @@ -0,0 +1,43 @@
    +<!--
    +Licensed to the Apache Software Foundation (ASF) under one or more
    +contributor license agreements.  See the NOTICE file distributed with
    +this work for additional information regarding copyright ownership.
    +The ASF licenses this file to You under the Apache License, Version 2.0
    +(the "License"); you may not use this file except in compliance with
    +the License.  You may obtain a copy of the License at
    +
    +    http://www.apache.org/licenses/LICENSE-2.0
    +
    +Unless required by applicable law or agreed to in writing, software
    +distributed under the License is distributed on an "AS IS" BASIS,
    +WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    +See the License for the specific language governing permissions and
    +limitations under the License.
    +-->
    +
    +# Contributors Guide
    +
    + If you believe that you have found a bug, please search for an existing [issue](https://issues.apache.org/jira/browse/accumulo) to see if it has already been reported. If you would like to add a new feature to Accumulo, please send an email with your idea to the [dev](mailto:[hidden email]) mail list. If it's appropriate, then we will create a ticket and assign it to you.
    +
    +## Development
    +
    +- See the [Developer's Guide](https://accumulo.apache.org/contributor/source) for information regarding common build commands, IDE setup and more.
    +- Ensure that your work targets the correct branch
    +- Add / update unit and integration tests
    +
    +## Patch Submission
    --- End diff --
   
    Unfortunately, the one that the automated code formatting does not over is imports.  For the Fluo, the docs explicitly state how imports should be organized (and how to do that in different IDEs).  Should that be added here?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|

[GitHub] accumulo pull request #265: ACCUMULO-4647 - start of contributor guide

ctubbsii
In reply to this post by ctubbsii
Github user dlmarion commented on a diff in the pull request:

    https://github.com/apache/accumulo/pull/265#discussion_r120391771
 
    --- Diff: CONTRIBUTING.md ---
    @@ -0,0 +1,43 @@
    +<!--
    +Licensed to the Apache Software Foundation (ASF) under one or more
    +contributor license agreements.  See the NOTICE file distributed with
    +this work for additional information regarding copyright ownership.
    +The ASF licenses this file to You under the Apache License, Version 2.0
    +(the "License"); you may not use this file except in compliance with
    +the License.  You may obtain a copy of the License at
    +
    +    http://www.apache.org/licenses/LICENSE-2.0
    +
    +Unless required by applicable law or agreed to in writing, software
    +distributed under the License is distributed on an "AS IS" BASIS,
    +WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    +See the License for the specific language governing permissions and
    +limitations under the License.
    +-->
    +
    +# Contributors Guide
    +
    + If you believe that you have found a bug, please search for an existing [issue](https://issues.apache.org/jira/browse/accumulo) to see if it has already been reported. If you would like to add a new feature to Accumulo, please send an email with your idea to the [dev](mailto:[hidden email]) mail list. If it's appropriate, then we will create a ticket and assign it to you.
    +
    +## Development
    +
    +- See the [Developer's Guide](https://accumulo.apache.org/contributor/source) for information regarding common build commands, IDE setup and more.
    +- Ensure that your work targets the correct branch
    +- Add / update unit and integration tests
    +
    +## Patch Submission
    +
    +- Ensure that Accumulo builds cleanly before submiting your patch using the command: `mvn clean verify`
    --- End diff --
   
    Do we want to skip ITs if they create or update one? I think we would want the command that runs the fastest that also completes all the checks. Not sure what that is...


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|

[GitHub] accumulo pull request #265: ACCUMULO-4647 - start of contributor guide

ctubbsii
In reply to this post by ctubbsii
Github user mjwall commented on a diff in the pull request:

    https://github.com/apache/accumulo/pull/265#discussion_r120392283
 
    --- Diff: CONTRIBUTING.md ---
    @@ -0,0 +1,43 @@
    +<!--
    +Licensed to the Apache Software Foundation (ASF) under one or more
    +contributor license agreements.  See the NOTICE file distributed with
    +this work for additional information regarding copyright ownership.
    +The ASF licenses this file to You under the Apache License, Version 2.0
    +(the "License"); you may not use this file except in compliance with
    +the License.  You may obtain a copy of the License at
    +
    +    http://www.apache.org/licenses/LICENSE-2.0
    +
    +Unless required by applicable law or agreed to in writing, software
    +distributed under the License is distributed on an "AS IS" BASIS,
    +WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    +See the License for the specific language governing permissions and
    +limitations under the License.
    +-->
    +
    +# Contributors Guide
    +
    + If you believe that you have found a bug, please search for an existing [issue](https://issues.apache.org/jira/browse/accumulo) to see if it has already been reported. If you would like to add a new feature to Accumulo, please send an email with your idea to the [dev](mailto:[hidden email]) mail list. If it's appropriate, then we will create a ticket and assign it to you.
    +
    +## Development
    +
    +- See the [Developer's Guide](https://accumulo.apache.org/contributor/source) for information regarding common build commands, IDE setup and more.
    +- Ensure that your work targets the correct branch
    +- Add / update unit and integration tests
    +
    +## Patch Submission
    +
    +- Ensure that Accumulo builds cleanly before submiting your patch using the command: `mvn clean verify`
    +- Before submission please squash your commits using a message that starts with the JIRA issue number and a description of the changes.
    +- Patches should be submitted in the form of Pull Requests to the Apache Accumulo GitHub [repository](https://github.com/apache/accumulo/) or to the [Review Board](https://reviews.apache.org) accumulo repository.
    +
    +## Review
    +
    +- While everyone is welcome to review patches, at least one committer needs to review and approve your patch.
    --- End diff --
   
    Are we moving from Commit then Review to Review then Commit with this line?  Or is it clear that this only applied to contributors and potential contributors.  Perhaps that warrants another DISCUSS thread.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|

[GitHub] accumulo pull request #265: ACCUMULO-4647 - start of contributor guide

ctubbsii
In reply to this post by ctubbsii
Github user keith-turner commented on a diff in the pull request:

    https://github.com/apache/accumulo/pull/265#discussion_r120393233
 
    --- Diff: CONTRIBUTING.md ---
    @@ -0,0 +1,43 @@
    +<!--
    +Licensed to the Apache Software Foundation (ASF) under one or more
    +contributor license agreements.  See the NOTICE file distributed with
    +this work for additional information regarding copyright ownership.
    +The ASF licenses this file to You under the Apache License, Version 2.0
    +(the "License"); you may not use this file except in compliance with
    +the License.  You may obtain a copy of the License at
    +
    +    http://www.apache.org/licenses/LICENSE-2.0
    +
    +Unless required by applicable law or agreed to in writing, software
    +distributed under the License is distributed on an "AS IS" BASIS,
    +WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    +See the License for the specific language governing permissions and
    +limitations under the License.
    +-->
    +
    +# Contributors Guide
    +
    + If you believe that you have found a bug, please search for an existing [issue](https://issues.apache.org/jira/browse/accumulo) to see if it has already been reported. If you would like to add a new feature to Accumulo, please send an email with your idea to the [dev](mailto:[hidden email]) mail list. If it's appropriate, then we will create a ticket and assign it to you.
    +
    +## Development
    +
    +- See the [Developer's Guide](https://accumulo.apache.org/contributor/source) for information regarding common build commands, IDE setup and more.
    +- Ensure that your work targets the correct branch
    +- Add / update unit and integration tests
    +
    +## Patch Submission
    +
    +- Ensure that Accumulo builds cleanly before submiting your patch using the command: `mvn clean verify`
    --- End diff --
   
    Personally, I think we should require/suggest a quick command before submission.  Let Jenkins and Travis run longer commands and report to the PR.  I think requiring running a 2 to 3 hour command discourages PRs.  I suggest `mvn clean verify -DskipITs` as a good minimum for PRs.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|

[GitHub] accumulo pull request #265: ACCUMULO-4647 - start of contributor guide

ctubbsii
In reply to this post by ctubbsii
Github user dlmarion commented on a diff in the pull request:

    https://github.com/apache/accumulo/pull/265#discussion_r120393282
 
    --- Diff: CONTRIBUTING.md ---
    @@ -0,0 +1,43 @@
    +<!--
    +Licensed to the Apache Software Foundation (ASF) under one or more
    +contributor license agreements.  See the NOTICE file distributed with
    +this work for additional information regarding copyright ownership.
    +The ASF licenses this file to You under the Apache License, Version 2.0
    +(the "License"); you may not use this file except in compliance with
    +the License.  You may obtain a copy of the License at
    +
    +    http://www.apache.org/licenses/LICENSE-2.0
    +
    +Unless required by applicable law or agreed to in writing, software
    +distributed under the License is distributed on an "AS IS" BASIS,
    +WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    +See the License for the specific language governing permissions and
    +limitations under the License.
    +-->
    +
    +# Contributors Guide
    +
    + If you believe that you have found a bug, please search for an existing [issue](https://issues.apache.org/jira/browse/accumulo) to see if it has already been reported. If you would like to add a new feature to Accumulo, please send an email with your idea to the [dev](mailto:[hidden email]) mail list. If it's appropriate, then we will create a ticket and assign it to you.
    +
    +## Development
    +
    +- See the [Developer's Guide](https://accumulo.apache.org/contributor/source) for information regarding common build commands, IDE setup and more.
    +- Ensure that your work targets the correct branch
    +- Add / update unit and integration tests
    +
    +## Patch Submission
    --- End diff --
   
    I thought it was possible for the code formatting to organize the imports.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|

[GitHub] accumulo pull request #265: ACCUMULO-4647 - start of contributor guide

ctubbsii
In reply to this post by ctubbsii
Github user mjwall commented on a diff in the pull request:

    https://github.com/apache/accumulo/pull/265#discussion_r120393414
 
    --- Diff: CONTRIBUTING.md ---
    @@ -0,0 +1,43 @@
    +<!--
    +Licensed to the Apache Software Foundation (ASF) under one or more
    +contributor license agreements.  See the NOTICE file distributed with
    +this work for additional information regarding copyright ownership.
    +The ASF licenses this file to You under the Apache License, Version 2.0
    +(the "License"); you may not use this file except in compliance with
    +the License.  You may obtain a copy of the License at
    +
    +    http://www.apache.org/licenses/LICENSE-2.0
    +
    +Unless required by applicable law or agreed to in writing, software
    +distributed under the License is distributed on an "AS IS" BASIS,
    +WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    +See the License for the specific language governing permissions and
    +limitations under the License.
    +-->
    +
    +# Contributors Guide
    +
    + If you believe that you have found a bug, please search for an existing [issue](https://issues.apache.org/jira/browse/accumulo) to see if it has already been reported. If you would like to add a new feature to Accumulo, please send an email with your idea to the [dev](mailto:[hidden email]) mail list. If it's appropriate, then we will create a ticket and assign it to you.
    +
    +## Development
    +
    +- See the [Developer's Guide](https://accumulo.apache.org/contributor/source) for information regarding common build commands, IDE setup and more.
    +- Ensure that your work targets the correct branch
    +- Add / update unit and integration tests
    +
    +## Patch Submission
    +
    +- Ensure that Accumulo builds cleanly before submiting your patch using the command: `mvn clean verify`
    +- Before submission please squash your commits using a message that starts with the JIRA issue number and a description of the changes.
    +- Patches should be submitted in the form of Pull Requests to the Apache Accumulo GitHub [repository](https://github.com/apache/accumulo/) or to the [Review Board](https://reviews.apache.org) accumulo repository.
    +
    +## Review
    +
    +- While everyone is welcome to review patches, at least one committer needs to review and approve your patch.
    --- End diff --
   
    "Perhaps that warrants another DISCUSS thread."  - what I mean is that if this becomes a discussion on RTC vs CTR, I don't want do that on github as part of this PR


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|

[GitHub] accumulo pull request #265: ACCUMULO-4647 - start of contributor guide

ctubbsii
In reply to this post by ctubbsii
Github user keith-turner commented on a diff in the pull request:

    https://github.com/apache/accumulo/pull/265#discussion_r120394483
 
    --- Diff: CONTRIBUTING.md ---
    @@ -0,0 +1,43 @@
    +<!--
    +Licensed to the Apache Software Foundation (ASF) under one or more
    +contributor license agreements.  See the NOTICE file distributed with
    +this work for additional information regarding copyright ownership.
    +The ASF licenses this file to You under the Apache License, Version 2.0
    +(the "License"); you may not use this file except in compliance with
    +the License.  You may obtain a copy of the License at
    +
    +    http://www.apache.org/licenses/LICENSE-2.0
    +
    +Unless required by applicable law or agreed to in writing, software
    +distributed under the License is distributed on an "AS IS" BASIS,
    +WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    +See the License for the specific language governing permissions and
    +limitations under the License.
    +-->
    +
    +# Contributors Guide
    +
    + If you believe that you have found a bug, please search for an existing [issue](https://issues.apache.org/jira/browse/accumulo) to see if it has already been reported. If you would like to add a new feature to Accumulo, please send an email with your idea to the [dev](mailto:[hidden email]) mail list. If it's appropriate, then we will create a ticket and assign it to you.
    +
    +## Development
    +
    +- See the [Developer's Guide](https://accumulo.apache.org/contributor/source) for information regarding common build commands, IDE setup and more.
    +- Ensure that your work targets the correct branch
    +- Add / update unit and integration tests
    +
    +## Patch Submission
    +
    +- Ensure that Accumulo builds cleanly before submiting your patch using the command: `mvn clean verify`
    +- Before submission please squash your commits using a message that starts with the JIRA issue number and a description of the changes.
    +- Patches should be submitted in the form of Pull Requests to the Apache Accumulo GitHub [repository](https://github.com/apache/accumulo/) or to the [Review Board](https://reviews.apache.org) accumulo repository.
    +
    +## Review
    +
    +- While everyone is welcome to review patches, at least one committer needs to review and approve your patch.
    --- End diff --
   
    Personally I feel that `While everyone is welcome to review patches` has a slightly negative connotation.  Could change to the following.
   
    ```
    We welcome reviews from anyone.  Any commiter can approve and merge a PR.
    ```


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|

[GitHub] accumulo pull request #265: ACCUMULO-4647 - start of contributor guide

ctubbsii
In reply to this post by ctubbsii
Github user keith-turner commented on a diff in the pull request:

    https://github.com/apache/accumulo/pull/265#discussion_r120396006
 
    --- Diff: CONTRIBUTING.md ---
    @@ -0,0 +1,43 @@
    +<!--
    +Licensed to the Apache Software Foundation (ASF) under one or more
    +contributor license agreements.  See the NOTICE file distributed with
    +this work for additional information regarding copyright ownership.
    +The ASF licenses this file to You under the Apache License, Version 2.0
    +(the "License"); you may not use this file except in compliance with
    +the License.  You may obtain a copy of the License at
    +
    +    http://www.apache.org/licenses/LICENSE-2.0
    +
    +Unless required by applicable law or agreed to in writing, software
    +distributed under the License is distributed on an "AS IS" BASIS,
    +WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    +See the License for the specific language governing permissions and
    +limitations under the License.
    +-->
    +
    +# Contributors Guide
    +
    + If you believe that you have found a bug, please search for an existing [issue](https://issues.apache.org/jira/browse/accumulo) to see if it has already been reported. If you would like to add a new feature to Accumulo, please send an email with your idea to the [dev](mailto:[hidden email]) mail list. If it's appropriate, then we will create a ticket and assign it to you.
    +
    +## Development
    +
    +- See the [Developer's Guide](https://accumulo.apache.org/contributor/source) for information regarding common build commands, IDE setup and more.
    +- Ensure that your work targets the correct branch
    +- Add / update unit and integration tests
    +
    +## Patch Submission
    +
    +- Ensure that Accumulo builds cleanly before submiting your patch using the command: `mvn clean verify`
    +- Before submission please squash your commits using a message that starts with the JIRA issue number and a description of the changes.
    +- Patches should be submitted in the form of Pull Requests to the Apache Accumulo GitHub [repository](https://github.com/apache/accumulo/) or to the [Review Board](https://reviews.apache.org) accumulo repository.
    +
    +## Review
    +
    +- While everyone is welcome to review patches, at least one committer needs to review and approve your patch.
    --- End diff --
   
    Oh, the last sentence I suggested I think makes things more clearly `Any commiter can approve and merge a PR.`.
   
    I think we should write this guide such that it clearly implies CTR, as that is the current agreed upon way of working.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
12