[GitHub] accumulo pull request #266: ACCUMULO-4648 - Update voting text in build.sh s...

classic Classic list List threaded Threaded
8 messages Options
Reply | Threaded
Open this post in threaded view
|

[GitHub] accumulo pull request #266: ACCUMULO-4648 - Update voting text in build.sh s...

ctubbsii
GitHub user mikewalch opened a pull request:

    https://github.com/apache/accumulo/pull/266

    ACCUMULO-4648 - Update voting text in build.sh script

    Update to form email for voting.  If approved, will make this in 1.7, 1.8, and master.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/mikewalch/accumulo accumulo-4648

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/accumulo/pull/266.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #266
   
----
commit 1e5e73a44428ea257bdb215487493b33ce07f868
Author: Mike Walch <[hidden email]>
Date:   2017-06-06T18:05:41Z

    ACCUMULO-4648 - Update voting text in build.sh script

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|

[GitHub] accumulo issue #266: ACCUMULO-4648 - Update voting text in build.sh script

ctubbsii
Github user milleruntime commented on the issue:

    https://github.com/apache/accumulo/pull/266
 
    +1 I think this wording is reasonable.  I do remember a debate on deadline of voting occurring last year so others might have opinions on the matter.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|

[GitHub] accumulo pull request #266: ACCUMULO-4648 - Update voting text in build.sh s...

ctubbsii
In reply to this post by ctubbsii
Github user ctubbsii commented on a diff in the pull request:

    https://github.com/apache/accumulo/pull/266#discussion_r120983104
 
    --- Diff: assemble/build.sh ---
    @@ -138,8 +138,8 @@ Please vote one of:
     [ ] -1 - Because..., I do not accept...
     ... these artifacts as the $(green "$ver") release of Apache Accumulo.
     
    -This vote will end on $(green "$votedate")
    -($(green "$edtvotedate") / $(green "$pdtvotedate"))
    +This vote will remain open until at least $(green "$votedate") ($(green "$edtvotedate") / $(green "$pdtvotedate")).
    +Voting can continue after this deadline until the release manager sends an email ending the vote.
    --- End diff --
   
    A more succinct way of saying this:
    "Voting continues until the release manager declares it closed."


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|

[GitHub] accumulo pull request #266: ACCUMULO-4648 - Update voting text in build.sh s...

ctubbsii
In reply to this post by ctubbsii
Github user ctubbsii commented on a diff in the pull request:

    https://github.com/apache/accumulo/pull/266#discussion_r120982688
 
    --- Diff: assemble/build.sh ---
    @@ -138,8 +138,8 @@ Please vote one of:
     [ ] -1 - Because..., I do not accept...
     ... these artifacts as the $(green "$ver") release of Apache Accumulo.
     
    -This vote will end on $(green "$votedate")
    -($(green "$edtvotedate") / $(green "$pdtvotedate"))
    +This vote will remain open until at least $(green "$votedate") ($(green "$edtvotedate") / $(green "$pdtvotedate")).
    --- End diff --
   
    I'd prefer to keep the newline between the UTC date on the first line and the convenient timezone-specific dates on the next, because the line wrapping can make these hard to read otherwise.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|

[GitHub] accumulo pull request #266: ACCUMULO-4648 - Update voting text in build.sh s...

ctubbsii
In reply to this post by ctubbsii
Github user ctubbsii commented on a diff in the pull request:

    https://github.com/apache/accumulo/pull/266#discussion_r121461221
 
    --- Diff: assemble/build.sh ---
    @@ -138,8 +138,8 @@ Please vote one of:
     [ ] -1 - Because..., I do not accept...
     ... these artifacts as the $(green "$ver") release of Apache Accumulo.
     
    -This vote will end on $(green "$votedate")
    -($(green "$edtvotedate") / $(green "$pdtvotedate"))
    +This vote will remain open until at least $(green "$votedate") ($(green "$edtvotedate") / $(green "$pdtvotedate")).
    +Voting can continue after this deadline until the release manager sends an email ending the vote.
    --- End diff --
   
    Or, "Voting continues until the release manager sends an email closing the vote."


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|

[GitHub] accumulo pull request #266: ACCUMULO-4648 - Update voting text in build.sh s...

ctubbsii
In reply to this post by ctubbsii
Github user mikewalch commented on a diff in the pull request:

    https://github.com/apache/accumulo/pull/266#discussion_r121774582
 
    --- Diff: assemble/build.sh ---
    @@ -138,8 +138,8 @@ Please vote one of:
     [ ] -1 - Because..., I do not accept...
     ... these artifacts as the $(green "$ver") release of Apache Accumulo.
     
    -This vote will end on $(green "$votedate")
    -($(green "$edtvotedate") / $(green "$pdtvotedate"))
    +This vote will remain open until at least $(green "$votedate") ($(green "$edtvotedate") / $(green "$pdtvotedate")).
    --- End diff --
   
    Added back the newline


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|

[GitHub] accumulo pull request #266: ACCUMULO-4648 - Update voting text in build.sh s...

ctubbsii
In reply to this post by ctubbsii
Github user mikewalch commented on a diff in the pull request:

    https://github.com/apache/accumulo/pull/266#discussion_r121774635
 
    --- Diff: assemble/build.sh ---
    @@ -138,8 +138,8 @@ Please vote one of:
     [ ] -1 - Because..., I do not accept...
     ... these artifacts as the $(green "$ver") release of Apache Accumulo.
     
    -This vote will end on $(green "$votedate")
    -($(green "$edtvotedate") / $(green "$pdtvotedate"))
    +This vote will remain open until at least $(green "$votedate") ($(green "$edtvotedate") / $(green "$pdtvotedate")).
    +Voting can continue after this deadline until the release manager sends an email ending the vote.
    --- End diff --
   
    Updated to use your wording


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|

[GitHub] accumulo pull request #266: ACCUMULO-4648 - Update voting text in build.sh s...

ctubbsii
In reply to this post by ctubbsii
Github user asfgit closed the pull request at:

    https://github.com/apache/accumulo/pull/266


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---