[GitHub] accumulo pull request #280: Added code to determine Accumulo version from ru...

classic Classic list List threaded Threaded
7 messages Options
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] accumulo pull request #280: Added code to determine Accumulo version from ru...

ctubbsii
GitHub user lstav opened a pull request:

    https://github.com/apache/accumulo/pull/280

    Added code to determine Accumulo version from running tserver

    Fixes ACCUMULO-4061, tserver Accumulo version is now available.
   
    As discussed in #200, I separated the PRs for 4061 and 4558.
   
   


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/lstav/accumulo ACCUMULO-4061

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/accumulo/pull/280.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #280
   
----
commit 1424ff594d6c0dea3c69ede7c46e75ef95b4e69b
Author: Luis Tavarez <[hidden email]>
Date:   2017-07-18T23:58:58Z

    Added code to determine Accumulo version from running tserver

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] accumulo issue #280: Added code to determine Accumulo version from running t...

ctubbsii
Github user milleruntime commented on the issue:

    https://github.com/apache/accumulo/pull/280
 
    Looks good.  This is the minimum we need for now and can revisit the other changes later.  I can merge this since its already been discussed and reviewed elsewhere.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] accumulo issue #280: Added code to determine Accumulo version from running t...

ctubbsii
In reply to this post by ctubbsii
Github user ctubbsii commented on the issue:

    https://github.com/apache/accumulo/pull/280
 
    Does this change cause the new version field to appear in a REST endpoint anywhere? I don't see any monitor code changes, but if the object is being dumped to JSON, there may not need to be any explicit changes in the REST code.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] accumulo issue #280: Added code to determine Accumulo version from running t...

ctubbsii
In reply to this post by ctubbsii
Github user milleruntime commented on the issue:

    https://github.com/apache/accumulo/pull/280
 
    No its not in this PR.  I don't know if you or @lstav wanted it to be a REST endpoint but this just has the version added to Thrift and a getVersion to tserver.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] accumulo issue #280: Added code to determine Accumulo version from running t...

ctubbsii
In reply to this post by ctubbsii
Github user lstav commented on the issue:

    https://github.com/apache/accumulo/pull/280
 
    I figured that adding this to the REST endpoint would be on another PR, like @milleruntime said, this is just to add the version to Thrift and the method in tserver. I think that for that PR we could also include adding the version as a column on the Tserver page of the Monitor site.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] accumulo issue #280: Added code to determine Accumulo version from running t...

ctubbsii
In reply to this post by ctubbsii
Github user lstav commented on the issue:

    https://github.com/apache/accumulo/pull/280
 
    Closing since it was already merged, will add the version to the REST api on another PR


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] accumulo pull request #280: Added code to determine Accumulo version from ru...

ctubbsii
In reply to this post by ctubbsii
Github user lstav closed the pull request at:

    https://github.com/apache/accumulo/pull/280


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Loading...