[GitHub] accumulo pull request #284: ACCUMULO-4686 Fix upgrade process to set version...

classic Classic list List threaded Threaded
4 messages Options
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] accumulo pull request #284: ACCUMULO-4686 Fix upgrade process to set version...

ctubbsii
GitHub user ivakegg opened a pull request:

    https://github.com/apache/accumulo/pull/284

    ACCUMULO-4686 Fix upgrade process to set version in all volumes.

    The upgrade process was only setting the version in one of a multi-volume system.
    This fixes the code to set the version on all volumes.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/ivakegg/accumulo ACCUMULO-4686-1.8

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/accumulo/pull/284.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #284
   
----
commit 22c2b77d493d24cce6264c447e87fca782e33d32
Author: Ivan Bella <[hidden email]>
Date:   2017-07-26T17:52:01Z

    ACCUMULO-4686 Fix upgrade process to set version in all volumes.
   
    The upgrade process was only setting the version in one of a multi-volume system.
    This fixes the code to set the version on all volumes.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] accumulo issue #284: ACCUMULO-4686 Fix upgrade process to set version in all...

ctubbsii
Github user ivakegg commented on the issue:

    https://github.com/apache/accumulo/pull/284
 
    I did not realize we were still supporting changes in 1.7.....I will check.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] accumulo issue #284: ACCUMULO-4686 Fix upgrade process to set version in all...

ctubbsii
In reply to this post by ctubbsii
Github user ivakegg commented on the issue:

    https://github.com/apache/accumulo/pull/284
 
    yes, this applies to 1.7 as well.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] accumulo issue #284: ACCUMULO-4686 Fix upgrade process to set version in all...

ctubbsii
In reply to this post by ctubbsii
Github user joshelser commented on the issue:

    https://github.com/apache/accumulo/pull/284
 
    Hurm, in hindsight, did you happen to take a look at the feasibility of adding a unit test for the change to `updateAccumuloVersion(VolumeManager, int)`? Doesn't look like it would be too bad at a glance. Trying to check this in an IT would probably be more pain than its worth.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Loading...