[GitHub] accumulo pull request #286: ACCUMULO-4689 Do not set empty SSL store types

classic Classic list List threaded Threaded
6 messages Options
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] accumulo pull request #286: ACCUMULO-4689 Do not set empty SSL store types

ctubbsii
GitHub user joshelser opened a pull request:

    https://github.com/apache/accumulo/pull/286

    ACCUMULO-4689 Do not set empty SSL store types

    Setting an empty type will override Jetty's implicit default value
    of JKS (which is most likely what Accumulo users would use).

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/joshelser/accumulo 4689-ssl-store-type

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/accumulo/pull/286.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #286
   
----
commit 7a7047fa8194e4bb5c1769dac22b16ee4820414c
Author: Josh Elser <[hidden email]>
Date:   2017-07-31T17:00:53Z

    ACCUMULO-4689 Do not set empty SSL store types
   
    Setting an empty type will override Jetty's implicit default value
    of JKS (which is most likely what Accumulo users would use).

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] accumulo pull request #286: ACCUMULO-4689 Do not set empty SSL store types

ctubbsii
Github user joshelser closed the pull request at:

    https://github.com/apache/accumulo/pull/286


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] accumulo issue #286: ACCUMULO-4689 Do not set empty SSL store types

ctubbsii
In reply to this post by ctubbsii
Github user milleruntime commented on the issue:

    https://github.com/apache/accumulo/pull/286
 
    Just curious but why open a PR for only a few hours?  Even if the change is minor, seems like hardly enough time for review.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] accumulo issue #286: ACCUMULO-4689 Do not set empty SSL store types

ctubbsii
In reply to this post by ctubbsii
Github user joshelser commented on the issue:

    https://github.com/apache/accumulo/pull/286
 
    Read the JIRA issue, please. And, for the record, there is no obligation of review before commit.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] accumulo issue #286: ACCUMULO-4689 Do not set empty SSL store types

ctubbsii
In reply to this post by ctubbsii
Github user milleruntime commented on the issue:

    https://github.com/apache/accumulo/pull/286
 
    > there is no obligation of review before commit.
   
    Right, that's why I was wondering why you bothered with the PR.  
   
    I see your comments on JIRA, thanks.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] accumulo issue #286: ACCUMULO-4689 Do not set empty SSL store types

ctubbsii
In reply to this post by ctubbsii
Github user joshelser commented on the issue:

    https://github.com/apache/accumulo/pull/286
 
    > >    there is no obligation of review before commit.
   
    > Right, that's why I was wondering why you bothered with the PR.
   
    Personal preference. If someone wants to make time to review my code, I like to go out of my way to make it easier for them to do so. The level of confidence I have in a change determines on how long I'll wait for that. If it's truly trivial I won't (in this case specifically, there were two ways to implement it that were essentially the same thing. The irony is that the other implementation is actually what Billie had done previously)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Loading...