[GitHub] accumulo pull request #294: Accumulo 3652 sl4j refactoring

classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|

[GitHub] accumulo pull request #294: Accumulo 3652 sl4j refactoring

ctubbsii
GitHub user milleruntime opened a pull request:

    https://github.com/apache/accumulo/pull/294

    Accumulo 3652 sl4j refactoring

    Closes #32
    Rebase'd original commit from PR #32 onto master.  Then fixed any places where an exception was obscured by using the sl4j Logger method: `public void error(String format, Object arg1, Object arg2);` when the orignal method had logged the exception with `public void error(String msg, Throwable t);`.  I also removed an unrelated changes that had crept into the branch and then ran it against verify to fix any checkstyle issues.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/milleruntime/accumulo accumulo-3652

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/accumulo/pull/294.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #294
   
----
commit 7cd36ab07b590184f305d8610a38b87bd214e61c
Author: Bob Thorman <[hidden email]>
Date:   2015-05-04T13:23:51Z

    ACCUMULO-3652 Refactor for slf4j without string concatenation

commit 1fca91bb1455510741960499fab9399eae01e021
Author: Mike Miller <[hidden email]>
Date:   2017-08-24T21:21:44Z

    ACCUMULO-3652 Fixed obscured exceptions, unrelated changes

commit d56ecbec5b8b3b187c9bbf89eadfe00939a64208
Author: Mike Miller <[hidden email]>
Date:   2017-08-29T16:42:39Z

    ACCUMULO-3652 Checkstyle corrections

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---