Reverting performance improvements for 1.7

classic Classic list List threaded Threaded
3 messages Options
Reply | Threaded
Open this post in threaded view
|

Reverting performance improvements for 1.7

Keith Turner
Recently Mike and I have made some performance improvements.  We made
these to 1.7 and 1.8 branches.  I am thinking of reverting these
changes in the 1.7 branch and keeping them in the 1.8 branch.  My
thinking is that 1.7 is getting close to EOL, so lets keep it stable.
Mike is it ok if I revert your TableID changes in 1.7 branch when I
revert my changes?

I plan on continuing to make performance improvements to 1.8 and
master after doing the revert.  If anyone has any thoughts on making
changes like this in 1.8, please let me know.

Keith
Reply | Threaded
Open this post in threaded view
|

Re: Reverting performance improvements for 1.7

Michael Wall
+1 - looking forward to trying these out


On Fri, Feb 2, 2018 at 12:56 PM Keith Turner <[hidden email]> wrote:

> Recently Mike and I have made some performance improvements.  We made
> these to 1.7 and 1.8 branches.  I am thinking of reverting these
> changes in the 1.7 branch and keeping them in the 1.8 branch.  My
> thinking is that 1.7 is getting close to EOL, so lets keep it stable.
> Mike is it ok if I revert your TableID changes in 1.7 branch when I
> revert my changes?
>
> I plan on continuing to make performance improvements to 1.8 and
> master after doing the revert.  If anyone has any thoughts on making
> changes like this in 1.8, please let me know.
>
> Keith
>
Reply | Threaded
Open this post in threaded view
|

Re: Reverting performance improvements for 1.7

Mike Miller-2
In reply to this post by Keith Turner
+1 Sounds good, I agree.  We should be making the minimal amount of changes
to 1.7.  Code changes, even ones that improve performance, introduce more
risk than just simple bug fixes.

I think code changes that improve performance can be made in 1.8,
especially if the plans are to go straight to 1.9.

On Fri, Feb 2, 2018 at 12:56 PM, Keith Turner <[hidden email]> wrote:

> Recently Mike and I have made some performance improvements.  We made
> these to 1.7 and 1.8 branches.  I am thinking of reverting these
> changes in the 1.7 branch and keeping them in the 1.8 branch.  My
> thinking is that 1.7 is getting close to EOL, so lets keep it stable.
> Mike is it ok if I revert your TableID changes in 1.7 branch when I
> revert my changes?
>
> I plan on continuing to make performance improvements to 1.8 and
> master after doing the revert.  If anyone has any thoughts on making
> changes like this in 1.8, please let me know.
>
> Keith
>