Review Request: Patch for ACCUMULO-473 : transient rfile indexing

classic Classic list List threaded Threaded
3 messages Options
Reply | Threaded
Open this post in threaded view
|

Review Request: Patch for ACCUMULO-473 : transient rfile indexing

Keith Turner

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/5911/
-----------------------------------------------------------

Review request for accumulo.


Description
-------

A patch that dynamically creates transient indexes on cached rfile blocks.


This addresses bug ACCUMULO-473.
    https://issues.apache.org/jira/browse/ACCUMULO-473


Diffs
-----

  /trunk/core/src/main/java/org/apache/accumulo/core/file/blockfile/cache/CachedBlock.java 1359683
  /trunk/core/src/main/java/org/apache/accumulo/core/file/blockfile/cache/LruBlockCache.java 1359683
  /trunk/core/src/main/java/org/apache/accumulo/core/file/blockfile/impl/CachableBlockFile.java 1359683
  /trunk/core/src/main/java/org/apache/accumulo/core/file/rfile/BlockIndex.java PRE-CREATION
  /trunk/core/src/main/java/org/apache/accumulo/core/file/rfile/RFile.java 1359683
  /trunk/core/src/main/java/org/apache/accumulo/core/file/rfile/RelativeKey.java 1359683
  /trunk/core/src/test/java/org/apache/accumulo/core/file/rfile/RFileTest.java 1359683

Diff: https://reviews.apache.org/r/5911/diff/


Testing
-------


Thanks,

kturner

Reply | Threaded
Open this post in threaded view
|

Re: Review Request: Patch for ACCUMULO-473 : transient rfile indexing

Keith Turner

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/5911/
-----------------------------------------------------------

(Updated July 12, 2012, 11:38 p.m.)


Review request for accumulo.


Changes
-------

Someone suggested the previous patch went past interfaces. In this patch, RFile and the Cache are now cleanly separated.


Description
-------

A patch that dynamically creates transient indexes on cached rfile blocks.


This addresses bug ACCUMULO-473.
    https://issues.apache.org/jira/browse/ACCUMULO-473


Diffs (updated)
-----

  /trunk/core/src/main/java/org/apache/accumulo/core/file/blockfile/ABlockReader.java 1359683
  /trunk/core/src/main/java/org/apache/accumulo/core/file/blockfile/cache/BlockCache.java 1359683
  /trunk/core/src/main/java/org/apache/accumulo/core/file/blockfile/cache/CacheEntry.java 1359683
  /trunk/core/src/main/java/org/apache/accumulo/core/file/blockfile/cache/CachedBlock.java 1359683
  /trunk/core/src/main/java/org/apache/accumulo/core/file/blockfile/cache/LruBlockCache.java 1359683
  /trunk/core/src/main/java/org/apache/accumulo/core/file/blockfile/cache/SimpleBlockCache.java 1359683
  /trunk/core/src/main/java/org/apache/accumulo/core/file/blockfile/impl/CachableBlockFile.java 1359683
  /trunk/core/src/main/java/org/apache/accumulo/core/file/rfile/BlockIndex.java PRE-CREATION
  /trunk/core/src/main/java/org/apache/accumulo/core/file/rfile/RFile.java 1359683
  /trunk/core/src/main/java/org/apache/accumulo/core/file/rfile/RelativeKey.java 1359683
  /trunk/core/src/test/java/org/apache/accumulo/core/file/blockfile/cache/TestLruBlockCache.java 1359683
  /trunk/core/src/test/java/org/apache/accumulo/core/file/rfile/RFileTest.java 1359683

Diff: https://reviews.apache.org/r/5911/diff/


Testing
-------


Thanks,

kturner

Reply | Threaded
Open this post in threaded view
|

Re: Review Request: Patch for ACCUMULO-473 : transient rfile indexing

Eric Newton

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/5911/#review9104
-----------------------------------------------------------



/trunk/core/src/main/java/org/apache/accumulo/core/file/blockfile/impl/CachableBlockFile.java
<https://reviews.apache.org/r/5911/#comment19298>

    Does the code match the comment?  I'm missing where the key is being passed.



/trunk/core/src/main/java/org/apache/accumulo/core/file/blockfile/impl/CachableBlockFile.java
<https://reviews.apache.org/r/5911/#comment19299>

    Spelling: lenght


- Eric Newton


On July 12, 2012, 11:38 p.m., kturner wrote:

>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/5911/
> -----------------------------------------------------------
>
> (Updated July 12, 2012, 11:38 p.m.)
>
>
> Review request for accumulo.
>
>
> Description
> -------
>
> A patch that dynamically creates transient indexes on cached rfile blocks.
>
>
> This addresses bug ACCUMULO-473.
>     https://issues.apache.org/jira/browse/ACCUMULO-473
>
>
> Diffs
> -----
>
>   /trunk/core/src/main/java/org/apache/accumulo/core/file/blockfile/ABlockReader.java 1359683
>   /trunk/core/src/main/java/org/apache/accumulo/core/file/blockfile/cache/BlockCache.java 1359683
>   /trunk/core/src/main/java/org/apache/accumulo/core/file/blockfile/cache/CacheEntry.java 1359683
>   /trunk/core/src/main/java/org/apache/accumulo/core/file/blockfile/cache/CachedBlock.java 1359683
>   /trunk/core/src/main/java/org/apache/accumulo/core/file/blockfile/cache/LruBlockCache.java 1359683
>   /trunk/core/src/main/java/org/apache/accumulo/core/file/blockfile/cache/SimpleBlockCache.java 1359683
>   /trunk/core/src/main/java/org/apache/accumulo/core/file/blockfile/impl/CachableBlockFile.java 1359683
>   /trunk/core/src/main/java/org/apache/accumulo/core/file/rfile/BlockIndex.java PRE-CREATION
>   /trunk/core/src/main/java/org/apache/accumulo/core/file/rfile/RFile.java 1359683
>   /trunk/core/src/main/java/org/apache/accumulo/core/file/rfile/RelativeKey.java 1359683
>   /trunk/core/src/test/java/org/apache/accumulo/core/file/blockfile/cache/TestLruBlockCache.java 1359683
>   /trunk/core/src/test/java/org/apache/accumulo/core/file/rfile/RFileTest.java 1359683
>
> Diff: https://reviews.apache.org/r/5911/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> kturner
>
>