review board

classic Classic list List threaded Threaded
4 messages Options
Reply | Threaded
Open this post in threaded view
|

review board

J. Mark Owens
Hi,

I'm going through a lot of the Accumulo documentation as I look at
ACCUMULO-4714 and had a question about some of the information.

Is the review board documentation page still up to date and accurate? I
clicked the instance link  (https://reviews.apache.org/ ) and noticed
that the last entry for Accumulo is over a year old. Is this something
that is still actively utilized or should the information be revised in
some manner? Is Accumulo still using a Commit-Then-Review policy, etc?

Thanks,
Mark
Reply | Threaded
Open this post in threaded view
|

Re: review board

Christopher Tubbs-2
We don't really use Review Board as much any more. It's still an option, I
guess, but I think most people have found pull requests on GitHub to be
more friendly for review.
We are still CtR, but several of us have been doing more frequent reviews
as part of our individual workflows.

On Wed, Nov 1, 2017 at 12:29 PM J. Mark Owens <[hidden email]> wrote:

> Hi,
>
> I'm going through a lot of the Accumulo documentation as I look at
> ACCUMULO-4714 and had a question about some of the information.
>
> Is the review board documentation page still up to date and accurate? I
> clicked the instance link  (https://reviews.apache.org/ ) and noticed
> that the last entry for Accumulo is over a year old. Is this something
> that is still actively utilized or should the information be revised in
> some manner? Is Accumulo still using a Commit-Then-Review policy, etc?
>
> Thanks,
> Mark
Reply | Threaded
Open this post in threaded view
|

Re: review board

Josh Elser
In reply to this post by J. Mark Owens
Hey Mark,

Yup, we're still a CTR project. That should be captured on the website
on our governance page and would require a VOTE by the PMC to change.

We don't have any enforced means of mechanism to perform reviews. We
used to use Reviewboard a bit, but, as of late, more happens on Github
with the better integration that Infra has provided. For example, you'll
find that some projects expressly state certain systems as the ones that
must be used for code-review. It's not been an issue in Accumulo.

Re: CTR in practice, we do still have a bit of review happening before
commit -- it's up to the discretion of the committer. If it's not a
trivial change, you'll likely see the committer waiting for someone else
to take a look before pushing it. Low-volume and decent test coverage
helps make this a tenable process.

On 11/1/17 12:28 PM, J. Mark Owens wrote:

> Hi,
>
> I'm going through a lot of the Accumulo documentation as I look at
> ACCUMULO-4714 and had a question about some of the information.
>
> Is the review board documentation page still up to date and accurate? I
> clicked the instance linkĀ  (https://reviews.apache.org/ ) and noticed
> that the last entry for Accumulo is over a year old. Is this something
> that is still actively utilized or should the information be revised in
> some manner? Is Accumulo still using a Commit-Then-Review policy, etc?
>
> Thanks,
> Mark
Reply | Threaded
Open this post in threaded view
|

Re[2]: review board

J. Mark Owens
Thanks for the info.
mark

------ Original Message ------
From: "Josh Elser" <[hidden email]>
To: [hidden email]
Sent: 11/1/2017 12:38:16 PM
Subject: Re: review board

>Hey Mark,
>
>Yup, we're still a CTR project. That should be captured on the website
>on our governance page and would require a VOTE by the PMC to change.
>
>We don't have any enforced means of mechanism to perform reviews. We
>used to use Reviewboard a bit, but, as of late, more happens on Github
>with the better integration that Infra has provided. For example,
>you'll find that some projects expressly state certain systems as the
>ones that must be used for code-review. It's not been an issue in
>Accumulo.
>
>Re: CTR in practice, we do still have a bit of review happening before
>commit -- it's up to the discretion of the committer. If it's not a
>trivial change, you'll likely see the committer waiting for someone
>else to take a look before pushing it. Low-volume and decent test
>coverage helps make this a tenable process.
>
>On 11/1/17 12:28 PM, J. Mark Owens wrote:
>>Hi,
>>
>>I'm going through a lot of the Accumulo documentation as I look at
>>ACCUMULO-4714 and had a question about some of the information.
>>
>>Is the review board documentation page still up to date and accurate?
>>I clicked the instance link  (https://reviews.apache.org/ ) and
>>noticed that the last entry for Accumulo is over a year old. Is this
>>something that is still actively utilized or should the information be
>>revised in some manner? Is Accumulo still using a Commit-Then-Review
>>policy, etc?
>>
>>Thanks,
>>Mark